Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Satisfy linter, add inline comments, improve documentation #197

Merged
merged 3 commits into from
Jul 17, 2024

Conversation

amotl
Copy link
Member

@amotl amotl commented Jul 17, 2024

What the title says: Nothing serious, nor specific.

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.76%. Comparing base (302c44f) to head (ad44133).

Files Patch % Lines
cratedb_toolkit/adapter/pymongo/cursor.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #197   +/-   ##
=======================================
  Coverage   81.76%   81.76%           
=======================================
  Files          79       79           
  Lines        3213     3213           
=======================================
  Hits         2627     2627           
  Misses        586      586           
Flag Coverage Δ
influxdb 30.84% <0.00%> (ø)
main 59.97% <0.00%> (ø)
mongodb 39.24% <0.00%> (ø)
pymongo 42.35% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

amotl added 2 commits July 17, 2024 20:12
Because the `ordered` option of `insert_many` is not being honored yet,
the result order of returned documents is indeterministic.
Using `.sort("_id", pymongo.ASCENDING)` does not improve the situation.
@amotl amotl force-pushed the this-and-that-2 branch from 0306bb9 to ad44133 Compare July 17, 2024 18:12
@amotl amotl marked this pull request as ready for review July 17, 2024 18:16
@amotl amotl merged commit 7e9f136 into main Jul 17, 2024
27 checks passed
@amotl amotl deleted the this-and-that-2 branch July 17, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant